Conversation
artemru
reviewed
Oct 10, 2025
artemru
reviewed
Oct 10, 2025
artemru
reviewed
Oct 10, 2025
requirements-dev.txt
Outdated
| # Format | ||
| black==22.3.0 | ||
| black==25.1.0 | ||
| isort>=5.10.1 |
Contributor
There was a problem hiding this comment.
why not updating isort as well?
Contributor
Author
There was a problem hiding this comment.
Why not! Which version do you like? :)
artemru
reviewed
Oct 10, 2025
artemru
approved these changes
Oct 10, 2025
Contributor
artemru
left a comment
There was a problem hiding this comment.
(i would go with fs2>0.5.2 to be safe)
Co-authored-by: Artem Kozhevnikov <kozhevnikov.artem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why ?
SONAR depends on https://github.com/facebookresearch/fairseq2 which introduced a ton of backward-incompatible changes in its recent 0.5 version. We update our code in order to keep up (also addressing #78).
How ?
Mostly by syncing the changes from the internal repo, including:
Tokenizer=>TextTokenizer)BatchLayoutto describe batcheshandler.pytocheckpoint.pyandconfig.py)DependencyContainerfor registering models andDependencyResolverfor retrieving themAdditional changes, not directly required by fairseq2 migration:
requirements.txtandrequirements-dev.txtto use onlypyproject.tomlas a single referenceREADME.mdThe
sonar-spacepackage version gets upgraded from 0.4.0 to 0.5.0.Test plan
The Github CI + local integration tests (
python -m pytest tests/integration_tests/; you may need to remove~/.cache/fairseq2if there are any problems with fairseq2 assets)